I don’t think they’ll finish the Sagrada Familia in our life times given they started building it in 1882
I’ve been to both and both are lovely with lots of things to do and see. Barcelona is probably more touristy. Just toss a coin and whichever one doesn’t win you can go there next time.